Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): python hello example #101

Merged
merged 9 commits into from
May 10, 2020

Conversation

campionfellin
Copy link
Contributor

First pass at converting more-or-less the python into

to an actual example, that will be built by lerna with yarn build. We can use this to verify changes continue to work with python. It's also a great point of reference for python developers using cdk8s

Signed-off-by: campionfellin campionfellin@gmail.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: campionfellin <campionfellin@gmail.com>
@campionfellin campionfellin requested a review from eladb April 12, 2020 16:37
@campionfellin
Copy link
Contributor Author

@eladb this feels a bit odd, with package.json in it. Is there a different/better way to get lerna to build this?

@eladb
Copy link
Contributor

eladb commented Apr 13, 2020

@eladb this feels a bit odd, with package.json in it. Is there a different/better way to get lerna to build this?

You need package.json and that's fine. The problem is that this is going to be built against the published version of the CDK and not against the local build. To do that you'll need this to actually run after package, and you'll have to install the python module from dist/python instead of from PyPI.

Not 100% sure what's the best way to do that TBH.

Signed-off-by: campionfellin <campionfellin@gmail.com>
@campionfellin
Copy link
Contributor Author

@eladb I looked into it, and it seems I just needed the dependency on the cdk8s-cli, which is supplied by node_modules/.bin/cdk8s (which is in-place after a yarn install from lerna at the root of the repository).

I think folks can take the example and edit as-needed (remove package.json, add deps to Pipefile, etc), but this stands as a base starting point for users.

@campionfellin
Copy link
Contributor Author

@eladb let's merge this and the other python examples

@eladb eladb changed the title feat(example): Add hello-python example feat(example): python hello example May 10, 2020
@mergify
Copy link
Contributor

mergify bot commented May 10, 2020

Your pull request will be updated and merged automatically (do not update manually).

@mergify mergify bot merged commit e792d2b into cdk8s-team:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants