fix(cli): impossible to import two crds with same kind #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disambiguate crds with similar kinds by including the group in the generated module name. misc: - emit a log with the resource name. - normalize type names before calling `emitType`
eladb
force-pushed
the
benisrae/disambiguate-kind
branch
from
c1031b8 to
995a2f5
Compare
added 6 commits
May 26, 2020 13:39
This is a new module that includes the source generation capabilities of jsii.
Since cdk8s version is not a stable value, the snapshots will get invalidated. Patch the manifest and set the version to always be 999.999.999.
iliapolo
requested changes
May 26, 2020
added 2 commits
May 26, 2020 16:02
iliapolo
approved these changes
May 26, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disambiguate CRDs with similar kinds by including the group in the generated module name.
BREAKING CHANGE: the generated module names of imported CRDs now include the resource's group and not just its kind in order to ensure uniqueness. For example, when importing the Jenkins CRD, instead of 'imports/jenkins.ts
, we now haveimports/jenkins.io/jenkins.ts`.PascalCase.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license