This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix: bundle lambdas in script instead of command line #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #655 +/- ##
===========================================
+ Coverage 90.78% 95.65% +4.87%
===========================================
Files 8 4 -4
Lines 282 207 -75
Branches 52 30 -22
===========================================
- Hits 256 198 -58
+ Misses 25 9 -16
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
Bingjiling
previously approved these changes
Jul 18, 2022
| ensureDirectoryExistence(`${outputDir}\\${fileToMove}`); | ||
| fs.copyFileSync(`${inputDir}\\${fileToMove}`, `${outputDir}\\${fileToMove}`); | ||
| } |
There was a problem hiding this comment.
nit - No new line at end of file
…n-aws-deployment into cdk-lambdaBundleFix
Bingjiling
reviewed
Jul 19, 2022
| @@ -67,8 +66,9 @@ export default class RestHookHandler { | |||
| event: SQSEvent, | |||
| allowListPromise: Promise<{ [key: string]: AllowListInfo }>, | |||
| ): Promise<SQSBatchResponse> { | |||
| await ensureAsyncInit(allowListPromise); | |||
| console.log(allowListPromise); | |||
There was a problem hiding this comment.
Use logger.debug instead? The allowList might contain sensitive information that customers do not want in the log all the time.
Bingjiling
approved these changes
Jul 19, 2022
rsmayda
reviewed
Jul 19, 2022
Comment on lines
68
to
72
| ): Promise<SQSBatchResponse> { | ||
| await ensureAsyncInit(allowListPromise); | ||
| logger.debug(allowListPromise); | ||
| const allowList = await allowListPromise; | ||
| logger.debug(allowList); | ||
| const messages = event.Records.map((record: any): SubscriptionNotification => { |
There was a problem hiding this comment.
looks like you are no longer calling
await ensureAsyncInit(allowListPromise);did you mean for that?
rsmayda
reviewed
Jul 19, 2022
| `cp ${inputDir}\\bulkExport\\schema\\transitiveReferenceParams.json ${outputDir}\\bulkExport\\schema\\transitiveReferenceParams.json`, | ||
| `cp ${inputDir}\\bulkExport\\schema\\${PATIENT_COMPARTMENT_V3} ${outputDir}\\bulkExport\\schema\\${PATIENT_COMPARTMENT_V3}`, | ||
| `cp ${inputDir}\\bulkExport\\schema\\${PATIENT_COMPARTMENT_V4} ${outputDir}\\bulkExport\\schema\\${PATIENT_COMPARTMENT_V4}`, | ||
| `node scripts/build_lambda.js ${inputDir} ${outputDir} bulkExport\\glueScripts\\export-script.py`, |
There was a problem hiding this comment.
I think we will want forward slashes not back slashes - https://stackoverflow.com/a/38428899
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Created a script to move files as needed instead of using command line hooks. This resolves the failing action here https://github.com/awslabs/fhir-works-on-aws-deployment/actions/runs/2678017744
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.