feat(bedrock): adopt to cdk best practices #770
Conversation
Removed `readonly` from actionGroups and knowledgeBases to prevent jsii errors Signed-off-by: Maksim Tybar <61300968+maxtybar@users.noreply.github.com>
Modifed `addActionGroup` function Signed-off-by: Maksim Tybar <61300968+maxtybar@users.noreply.github.com>
| /** | ||
| * Instance of Agent | ||
| */ | ||
| readonly agentInstance: bedrock.CfnAgent; |
There was a problem hiding this comment.
I wouldn't include this in the interface, as this implies that to import an existing agent you would need to pass a CfnAgent. I think it would be better to define it only on the Agent Class as a private readonly (internal) attribute (example on CDK lib).
There was a problem hiding this comment.
@aws-rafams If you have available cycles please take a look at this. There is also issues with IKnowledgeBase on the build. Thanks!
Signed-off-by: Maksim Tybar <61300968+maxtybar@users.noreply.github.com>
|
We can also update the KB associateToAgent method to take an IAgent, allowing to associate an imported agent |
| } else { | ||
| this.role = new iam.Role(this, 'Role', { | ||
| assumedBy: new iam.ServicePrincipal('bedrock.amazonaws.com'), | ||
| roleName: generatePhysicalNameV2( |
There was a problem hiding this comment.
we need to use the new capability of generatePhysicalNameV2 here to avoid collisions with name generation
|
Closing this PR as we will start a new one with the agent refactoring |
Fixes #731 and #747
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.