fix(jsii): do not mark "any" or "unknown" as optional (unless "?") #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
approved these changes
Nov 7, 2018
There was a problem hiding this comment.
Sounds reasonable. I've opened #296 to track updating the spec so that we model optional and nullable as different concepts (optional should be modeled on the parameter, not on the type ref).
We accidentally marked every "any" and "unknown" types as optional, regardless if the declaration had a question mark or not. Fixes #284
eladb
force-pushed
the
benisrae/any-is-not-optional
branch
from
d532e64
to
9f9b015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally marked every "any" and "unknown" types as optional,
regardless if the declaration had a question mark or not.
Fixes #284
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.