fix(pacmak): fix .NET generated .csproj files using incorrect version for Amazon.JSII.Runtime #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Amazon.JSII.Runtime The generated .csproj file is currently using the same version for Package Version and the version for Amazon.JSII.Runtime.
ghost
requested review from
assyadh
approved these changes
Jun 29, 2019
rix0rrr
approved these changes
Jun 29, 2019
eladb
reviewed
Jun 30, 2019
|
They were. It's just that in the expected csproj, assembly.jsiiVersion and assembly.version carry the same value, so it had no impact on calc/calc-lib etc. |
|
Oh I see.... feels like we need some way to unit test this and/or add to conformance tests so this doesn’t repeat when we implement the next language generator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated .csproj file is currently using the same version for Package Version and the
version for Amazon.JSII.Runtime.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.