Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Support #319

Merged
merged 130 commits into from
Mar 12, 2019
Merged

Python Support #319

merged 130 commits into from
Mar 12, 2019

Conversation

dstufft
Copy link
Contributor

@dstufft dstufft commented Nov 21, 2018 •
edited
Loading

Compliance

  • primitiveTypes
  • dates
  • collectionTypes
  • dynamicTypes
  • unionTypes
  • createObjectAndCtorOverloads
  • getSetPrimitiveProperties
  • callMethods
  • unmarshallIntoAbstractType
  • getAndSetNonPrimitiveProperties
  • getAndSetEnumValues
  • useEnumFromScopedModule
  • undefinedAndNull
  • arrays
  • maps
  • dataTypes
  • unionPropertiesWithBuilder (skip)
  • exceptions
  • unionProperties (xfailing)
  • subclassing
  • testJSObjectLiteralToNative
  • testFluentApiWithDerivedClasses
  • creationOfNativeObjectsFromJavaScriptObjects
  • asyncOverrides_callAsyncMethod (xfailing)
  • asyncOverrides_overrideAsyncMethod (xfailing)
  • asyncOverrides_overrideAsyncMethodByParentClass (xfailing)
  • asyncOverrides_overrideCallsSuper (xfailing)
  • asyncOverrides_twoOverrides (xfailing)
  • asyncOverrides_overrideThrows (xfailing)
  • syncOverrides (xfailing)
  • propertyOverrides_get_set (xfailing)
  • propertyOverrides_get_calls_super (xfailing)
  • propertyOverrides_set_calls_super (xfailing)
  • propertyOverrides_get_throws (xfailing)
  • propertyOverrides_set_throws (xfailing)
  • propertyOverrides_interfaces (skip?)
  • interfaceBuilder
  • syncOverrides_callsSuper (xfailing)
  • fail_syncOverrides_callsDoubleAsync_method (xfailing)
  • fail_syncOverrides_callsDoubleAsync_propertyGetter (xfailing)
  • fail_syncOverrides_callsDoubleAsync_propertySetter (xfailing)
  • testInterfaces (xfailing)
  • testNativeObjectsWithInterfaces (xfailing)
  • testLiteralInterface (xfailing)
  • testInterfaceParameter (xfailing)
  • structs_stepBuilders
  • structs_buildersContainNullChecks
  • structs_serializeToJsii
  • statics
  • consts
  • reservedKeywordsAreSlugifiedInMethodNames
  • nodeStandardLibrary (xfailing)
  • returnAbstract (xfailing)
  • doNotOverridePrivates_method_public
  • doNotOverridePrivates_method_private
  • doNotOverridePrivates_property_by_name_private
  • doNotOverridePrivates_property_by_name_public
  • doNotOverridePrivates_property_getter_public
  • doNotOverridePrivates_property_getter_private
  • classWithPrivateConstructorAndAutomaticProperties
  • nullShouldBeTreatedAsUndefined
  • testJsiiAgent
  • receiveInstanceOfPrivateClass (xfailing)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dstufft
Initial Python Runtime Support
4b8af49
@dstufft
Bump versions
fa291d7
@dstufft
Upgrade for latest JSII
3180d97
@dstufft
Handle non-primitive types being returned from JSII runtime
1a9297c
@dstufft
Switch to using a single, global Kernel
c4c652d
@dstufft
Rearrange imports to deal with import cycles
a162358
@dstufft
Provide a mechanism to load JSII Assemblies
59c7876
@dstufft
Add the WIP Python target for pacmak
ad57330
@dstufft
Prefix all of our interal names with _
0e4225f
@dstufft
Write out an __all__ that lists our exported names
89e4422
@dstufft
Add support for more types
15546d7
@dstufft
Fix some MyPy errors
6b1cbd6
@dstufft
Generate actual Python packages
882e5c7
@dstufft
Correct the name of the import JSIIAssembly
0e34a80
@dstufft
Produce packages for the JSII Python Runtime
5ea945d
@dstufft
Embed the jsii-runtime within the jsii-python-runtime
8275944
@dstufft
Merge branch 'master' into python
50ad810
@dstufft
Handle collection types in JSII
21f7ecb
@dstufft
Handle scoped packages
e2708e0
@dstufft
Handle the case where a JSII name conflicts with a Python keyword
340f8e9
@dstufft
Work with PEP 420 style namespace pacages
ea14b3c
@dstufft
Deduplicate imports
2f93077
@dstufft
Remove some debug output
9d6362f
@dstufft
Add support for Union types
0cb0ad5
@dstufft
Add support for interfaces
90b8ebe
@dstufft
Fix setup.py to always include JSII assembly
507f787
@dstufft
Handle recurisve generic collection types
653d774
@dstufft
Handle classes and interfaces without bodies
52f62d8
@dstufft
Use a better mechanism of extracting a list of types
0408cb3
@dstufft
Add a bit of extra documentation
b8b40c0
@dstufft dstufft requested a review from costleya as a code owner February 27, 2019 20:58
garnaat
garnaat approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@garnaat garnaat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Ship it.

Just need to get the wheel dependency baked into the build image for the tests to pass.

@eladb
Copy link
Contributor

eladb commented Mar 11, 2019

Milestone!

@dstufft dstufft closed this Mar 11, 2019
@dstufft dstufft reopened this Mar 11, 2019
@dstufft dstufft force-pushed the dstufft/python-support branch from 5c59915 to afa8ced Compare March 11, 2019 14:03
@dstufft dstufft closed this Mar 12, 2019
@dstufft dstufft reopened this Mar 12, 2019
@dstufft dstufft force-pushed the dstufft/python-support branch 4 times, most recently from 480ceec to 1ea8652 Compare March 12, 2019 17:33
@dstufft dstufft force-pushed the dstufft/python-support branch from 1ea8652 to cce6d4b Compare March 12, 2019 19:11
@dstufft dstufft changed the title [WIP] Python Support Python Support Mar 12, 2019
@dstufft dstufft merged commit cc3ec87 into master Mar 12, 2019
@dstufft dstufft deleted the dstufft/python-support branch March 12, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@garnaat garnaat garnaat approved these changes

@costleya costleya Awaiting requested review from costleya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstufft @eladb @garnaat @rix0rrr