Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make execution of pack.sh much faster #43

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

RomainMuller
Copy link
Contributor

ℹ️ This change is identical to aws/aws-cdk#161

Since the pack.sh script is supposed to be run after build.sh was
executed, the prepare script of all packages was already performed,
and it is possible to only run the prepublish script, then execute
npm pack --ignore-scripts in parallel.

This removes the double-compilation of all packages (including
slow-to-build packages such as aws-cdk-docs or @aws-cdk/resources,
that involve expensive code generation).

Since the `pack.sh` script is supposed to be run after `build.sh` was
executed, the `prepare` script of all packages was already performed,
and  it is possible to only run the `prepublish` script, then execute
`npm pack --ignore-scripts` in parallel.

This removes the double-compilation of all packages (including
slow-to-build packages such as `aws-cdk-docs` or `@aws-cdk/resources`,
that involve expensive code generation).
@RomainMuller RomainMuller requested a review from eladb June 21, 2018 14:14
@RomainMuller RomainMuller merged commit d213f98 into master Jun 26, 2018
@RomainMuller RomainMuller deleted the rmuller/make-pack-sh-faster branch June 26, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants