Support AWS-LC in FIPS mode #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2024 13:35
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 90.15% 90.16% +0.01%
==========================================
Files 175 175
Lines 31396 31408 +12
==========================================
+ Hits 28306 28320 +14
+ Misses 3090 3088 -2 ☔ View full report in Codecov by Sentry. |
tomleavy
previously approved these changes
Oct 17, 2024
stefunctional
approved these changes
Oct 18, 2024
tomleavy
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
X509_get0_pubkeyso it's replaced byX509_get_pubkeywhich differs in requiringfreeof the keyBIO_number_writtenand now it returnsu64instead ofusize. This is not the case for FIPS.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.