Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor outputFormat Parameter #117

Closed

Conversation

leviwilson
Copy link

Fixes

Description

This PR fixes #116 by allowing the outputFormat to be specified in the JSON request when the requestType: "Default".

This allows for the consumer to control what format the returned image is in according to what is allowable by Sharp#toFormat

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

-w /development \
amazonlinux:2018.03 ./package.sh $DIST_OUTPUT_BUCKET $TEMPLATE_OUTPUT_BUCKET $VERSION
```

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this so I could locally have a repeatable build from a non-amazonlinux distro

@leviwilson
Copy link
Author

@shsenior get a chance to look at this yet? Wasn't sure who the other maintainers were.

Feedback welcome.

@leviwilson
Copy link
Author

@hayesry or anyone else?

@hayesry
Copy link
Member

hayesry commented Aug 4, 2019

@leviwilson - added for review, thanks for contributing!

@martin-mueller-solutions

Any news on this?

@leviwilson
Copy link
Author

Any news on this?

Nope. @hayesry is there any sort of information to look to see what the process is for getting PRs into awslabs repositories?

There is a lot of interest (or so it seems) from the community and to be honest the cadence in which PRs are reviewed (even well after they are added for review) is incredibly long.

From the perspective of those that wish to contribute it's discouraging / disincentivizing if that feedback loop is over a quarter of the year.

@beomseoklee
Copy link
Member

Thanks for your effort here, @leviwilson
We have updated our solution, and your pull request has been merged into our master branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here

@kjanoudi
Copy link

kjanoudi commented Jun 9, 2020

@leviwilson would there be a need to be able to provide the options parameter for the toFormat function? https://sharp.pixelplumbing.com/api-output#toformat

@leviwilson
Copy link
Author

@kjanoudi unsure? The need I'd had was simply to specify the output format, so I didn't dig too much into the other optional arguments.

@leoschenkel
Copy link

Hi there I'd like to set output options to the PNG outputFormat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputFormat option not honored
7 participants