RFC: Callbacks for ByteStream and SdkBody
#1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
update: Arc callbacks instead of boxing them remove: most bounds from ByteStreamReadCallback trait add: PartialEq/Eq impl for Inner that disregards callback list
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
rcoh
reviewed
Apr 7, 2022
There was a problem hiding this comment.
I think we'll need to do some refactoring to SdkBody/ByteStream. As it stands, on the request side, we quickly call into_inner on the ByteStream prior to passing it into the Hyper—this means that the checksumming can't be solely inside of ByteStream (or we need to have ByteStream impl Body directly?
Perhaps we should just teach SdkBody about the callbacks, albeit, through a private interface?
There's a lot of design options here, probably some prototyping is required.
update: RFC with checksum callback example
Velfi
changed the title
ByteStream and SdkBody
jdisanti
reviewed
Apr 11, 2022
Velfi
changed the title
ByteStream and SdkBodyByteStream and SdkBody
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
jdisanti
reviewed
Apr 15, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Velfi
commented
Apr 15, 2022
Comment on lines
23
to
26
| /// This callback is called once all chunks have been read. If the callback encountered 1 or more errors | ||
| /// while running `update`s, this is how those errors are raised. Implementors may return a [`HeaderMap`][HeaderMap] | ||
| /// that will be appended to the HTTP body as a trailer. This is only useful to do for streaming requests. | ||
| fn trailers(&self) -> Result<Option<HeaderMap<HeaderValue>>, BoxError> { Ok(None) } |
There was a problem hiding this comment.
I think that for SdkBody I can have it inspect itself and only append trailers if the inner variant is Inner::Streaming but I'm not sure that covers every streaming request case.
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This RFC demonstrates how we could add callback that get triggered when reading chunks from a
ByteStreamorSdkBody. The RFC also contains one example of how we could use these callbacks to implement a checksum validator for requests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.