Remove our base64
implementation in favour of base64-simd
#1938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes (#1277), that is, the following protocol tests now pass:
Description
base64-simd
requires Rust 1.62.1 to build, so I had to upgrade it here.Performance
base64-simd
is around 30% to 500% faster than our previous hand-rolled implementation (on my M1 MBP at least).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.