Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationShape::NAME as ShapeId #2678

Merged
merged 18 commits into from
May 11, 2023
Merged

OperationShape::NAME as ShapeId #2678

merged 18 commits into from
May 11, 2023

Conversation

82marbag
Copy link
Contributor

@82marbag 82marbag commented May 8, 2023

See #2634

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@hlbarber hlbarber added breaking-change This will require a breaking change server Rust server SDK labels May 9, 2023
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Copy link
Contributor

@hlbarber hlbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rust-runtime/aws-smithy-http-server/src/extension.rs Outdated Show resolved Hide resolved
@82marbag 82marbag marked this pull request as ready for review May 10, 2023 08:14
@82marbag 82marbag requested a review from a team as a code owner May 10, 2023 08:14
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@82marbag 82marbag enabled auto-merge May 10, 2023 08:30
@82marbag 82marbag disabled auto-merge May 10, 2023 08:30
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@82marbag 82marbag requested a review from a team as a code owner May 10, 2023 11:18
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@hlbarber hlbarber added the next-release fixes / updates that need to be merged prior to release label May 10, 2023
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@smithy-lang smithy-lang deleted a comment from github-actions bot May 11, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot May 11, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot May 11, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot May 11, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot May 11, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot May 11, 2023
@82marbag 82marbag enabled auto-merge May 11, 2023 13:02
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@82marbag 82marbag added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit 9b340fb May 11, 2023
@82marbag 82marbag deleted the introduce-shapeid branch May 11, 2023 15:27
82marbag pushed a commit that referenced this pull request May 12, 2023
This reverts commit 9b340fb.

It is a breaking change and it will be included in the next release.
82marbag added a commit that referenced this pull request May 12, 2023
This reverts commit 9b340fb.

It is a breaking change and it will be included in the next release.
82marbag added a commit that referenced this pull request May 12, 2023
This reverts #2678.

It is a breaking change and it will be included in the next release.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
david-perez pushed a commit that referenced this pull request May 18, 2023
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez pushed a commit that referenced this pull request May 18, 2023
This reverts #2678.

It is a breaking change and it will be included in the next release.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
82marbag added a commit that referenced this pull request May 22, 2023
See #2634

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez pushed a commit that referenced this pull request May 22, 2023
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez pushed a commit that referenced this pull request May 22, 2023
This reverts #2678.

It is a breaking change and it will be included in the next release.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
david-perez pushed a commit that referenced this pull request May 22, 2023
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez pushed a commit that referenced this pull request May 22, 2023
This reverts #2678.

It is a breaking change and it will be included in the next release.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
hlbarber added a commit that referenced this pull request Jun 9, 2023
See #2634

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Co-authored-by: Harry Barber <106155934+hlbarber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change next-release fixes / updates that need to be merged prior to release server Rust server SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants