Simplify Plugin trait
#2740
Simplify Plugin trait
#2740
Conversation
hlbarber
added
ergonomics
breaking-change
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
force-pushed
the
harryb/simplify-plugin
branch
from
9125888
to
1d1afaf
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/DocHandlerGenerator.kt
Show resolved
Hide resolved
| #{SmithyHttpServer}::operation::UpgradePlugin::<UpgradeExtractors>: #{SmithyHttpServer}::plugin::Plugin< | ||
| #{Protocol}, | ||
| crate::operation_shape::$structName, | ||
| ModelPlugin::Service | ||
| >, |
There was a problem hiding this comment.
Why is this bound needed? Isn't it satisfied by the blanket impl<S, P, Op, Extractors> Plugin<P, Op, S> for UpgradePlugin<Extractors>?
| /// ## let app: $serviceName<#{SmithyHttpServer}::routing::Route<#{SmithyHttp}::body::SdkBody>> = app; | ||
| /// ``` | ||
| /// | ||
| pub fn ${fieldName}_service<S, ServiceExtractors, UpgradeExtractors>(self, service: S) -> Self |
There was a problem hiding this comment.
Why now suffixing with _service instead of _operation like before?
There was a problem hiding this comment.
Previously, we were accepting Operation<S, L>. Now we're accepting a tower::Service which satisfies the operation signature.
...otlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServerServiceGenerator.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
#2444
Description
Plugin, make it closer toLayer.Operation.