Fix name collision in generated union functions #643
Conversation
| @@ -0,0 +1,53 @@ | |||
| $version: "1.0" | |||
| namespace naming_obs_structs | |||
There was a problem hiding this comment.
I wanted to put this test into the existing naming-obstacle-course.smithy, but that one already defines operation Result, which would conflict unless it was in a different namespace.
I'm open to ideas here since I dislike the names here (ops vs structs) as they don't really make that much sense. Can we have a larger multi-namespace, multi-file, naming-obstacle-course service that still checks things such as the namespace being crate?
There was a problem hiding this comment.
not really, one service is one namespace. We could use renames but that would of course, defeat the purpose
There was a problem hiding this comment.
I think you can have nested namespaces in Smithy, so there's a chance this might work. No idea how our codegen handles it though.
2 participants
Motivation and Context
The
UnionGeneratorwas generated functions that returned aResultthat wasn't fully qualified, and this would fail if the service model also had a structure in it namedResult(as is the case withtranscribestreaming).Description
This PR fixes the name collision and adds a naming obstacle course test for it.
Testing
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.