Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate OperationExtension and add Plugin #2157

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Undeprecate OperationExtension and add Plugin #2157

merged 4 commits into from
Jan 10, 2023

Conversation

hlbarber
Copy link
Contributor

@hlbarber hlbarber commented Jan 3, 2023

Motivation and Context

There still exist use cases for a central OperationExtension.

Description

  • Undeprecate OperationExtension
  • Add OperationExtensionPlugin

@hlbarber hlbarber requested a review from a team as a code owner January 3, 2023 14:13
@hlbarber hlbarber requested review from jdisanti and crisidev and removed request for jdisanti and crisidev January 3, 2023 14:13
@hlbarber hlbarber force-pushed the harryb/undeprecate-operation-exts branch from 5198e55 to 76a6070 Compare January 4, 2023 12:08
@hlbarber hlbarber force-pushed the harryb/undeprecate-operation-exts branch from 76a6070 to fba7cff Compare January 4, 2023 12:09
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

@smithy-lang smithy-lang deleted a comment from github-actions bot Jan 6, 2023
jjant
jjant reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@jjant jjant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There still exist use cases for a central OperationExtension.

Can you add an example?

@hlbarber
Copy link
Contributor Author

hlbarber commented Jan 10, 2023 •
edited
Loading

Can you add an example?

Added into aws_smithy_http_server examples 413bd8a with a description of the usage.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@hlbarber hlbarber enabled auto-merge (squash) January 10, 2023 15:17
@hlbarber hlbarber merged commit f75d4f9 into main Jan 10, 2023
@hlbarber hlbarber deleted the harryb/undeprecate-operation-exts branch January 10, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjant jjant jjant approved these changes

Assignees
No one assigned
Labels
server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlbarber @jjant @Velfi