Fix quoted text grammar and parsing #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Smithy ABNF for QuotedChar and TextBlock, and updates IdlTextParser to properly parse QuotedChar and TextBlock. Previously, IdlTextParser was allowing any character to be used as a QuotedChar, despite QuotedChar having certain restrictions in the grammar. IdlTextParser was updated to follow the grammar's restrictions properly. The grammar restrictions were also loosened to allow tab characters in QuotedChar and double quotes in TextBlock, both of which were already in use. Specifically for double quotes in a TextBlock, one or two are allowed in a row, and must be followed by a QuotedChar.
mtdowling
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Smithy ABNF for QuotedChar and TextBlock, and updates IdlTextParser to properly parse QuotedChar and TextBlock. Previously, IdlTextParser was allowing any character to be used as a QuotedChar, despite QuotedChar having certain restrictions in the grammar. IdlTextParser was updated to follow the grammar's restrictions properly. The grammar restrictions were also loosened to allow tab characters in QuotedChar and double quotes in TextBlock, both of which were already in use. Specifically for double quotes in a TextBlock, one or two are allowed in a row, and must be followed by a QuotedChar.
Issue #, if available:
#1491
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.