Add selector compliance tests #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
selector
branch
6 times, most recently
from
0a2b3f0 to
18ca629
Compare
JordonPhillips
requested changes
Mar 3, 2023
smithy-model/src/test/java/software/amazon/smithy/model/selector/SelectorRunnerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/resources/software/amazon/smithy/model/selector/cases/functions.smithy
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/selector/SelectorRunnerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/selector/SelectorRunnerTest.java
Outdated
Show resolved
Hide resolved
...-model/src/test/resources/software/amazon/smithy/model/selector/cases/scope-attribute.smithy
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
selector
branch
2 times, most recently
from
2dc880a to
2badf4d
Compare
JordonPhillips
requested changes
Mar 6, 2023
smithy-model/src/test/java/software/amazon/smithy/model/selector/SelectorRunnerTest.java
Outdated
Show resolved
Hide resolved
JordonPhillips
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Create self-contained compliance tests for selectors to make them safer to evolve and bugfix, and to make it possible for other implementations to just copy/paste our self-contained directory of test cases.
Most of the test cases are based on examples in the selectors documentation
TODO: Create a follow-up PR for porting existing selector test cases into this format
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.