Fix truncated environment variable expansions #662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any environment variable expansions in smithy-build.json that did not start at the beginning of the field resulted in dropping the character that preceded the ${NAME} placeholder.
Consider the following
smithy-build.json
example, with the environment variable ofFOO
was set toBAZ
:Currently, this results in the shapes with the tag
BABAZ
being included, instead ofBARBAZ
as expected.This CR corrects the expansion behavior to assure preceding characters are included appropriately.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.