Warn when using jsonAdd with schemas #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
approved these changes
Jun 30, 2021
Using the jsonAdd feature with the Smithy to OpenAPI converter is probably never what you actually want to do. It means that clients, servers, and other artifacts generated from the Smithy model don't know about the shapes being defined only in OpenAPI. This PR adds a severe log warning when this is detected.
mtdowling
force-pushed
the
warn-about-json-add-with-schemas
branch
from
8a58e5a to
4e003af
Compare
kstich
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the jsonAdd feature with the Smithy to OpenAPI converter is
probably never what you actually want to do. It means that clients,
servers, and other artifacts generated from the Smithy model don't know
about the shapes being defined only in OpenAPI. This PR adds a severe
log warning when this is detected.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.