Add default trait design doc #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
reviewed
Sep 25, 2021
mtdowling
force-pushed
the
add-default-trait
branch
from
a271445 to
7f355c8
Compare
mtdowling
force-pushed
the
add-default-trait
branch
from
7f355c8 to
ff0ec7d
Compare
Baccata
reviewed
Oct 26, 2021
Baccata
reviewed
Oct 26, 2021
Baccata
reviewed
Oct 26, 2021
Baccata
reviewed
Oct 26, 2021
Baccata
reviewed
Oct 26, 2021
mtdowling
force-pushed
the
add-default-trait
branch
from
aa8a27d to
22ed072
Compare
Baccata
reviewed
Nov 8, 2021
Baccata
reviewed
Nov 8, 2021
Baccata
reviewed
Nov 8, 2021
mtdowling
force-pushed
the
add-default-trait
branch
from
22ed072 to
c2a1ffa
Compare
JordonPhillips
force-pushed
the
idl-2.0
branch
3 times, most recently
from
437cff5 to
9a1a8e4
Compare
mtdowling
force-pushed
the
add-default-trait
branch
from
c2a1ffa to
6a4074d
Compare
kstich
reviewed
Dec 9, 2021
JordonPhillips
previously requested changes
Dec 10, 2021
mtdowling
force-pushed
the
add-default-trait
branch
2 times, most recently
from
89f5117 to
989c90e
Compare
kstich
approved these changes
Dec 17, 2021
mtdowling
force-pushed
the
add-default-trait
branch
from
989c90e to
c06f017
Compare
mtdowling
dismissed
JordonPhillips’s stale review
Comments addressed. GitHub is being weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.