implementation of inlined operation input / output shapes #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Oct 27, 2021
...sources/software/amazon/smithy/model/loader/invalid/inline-io/inline-structure-member.smithy
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/resources/software/amazon/smithy/model/loader/valid/inline-io.smithy
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Oct 27, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlNodeParser.java
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
inline-io-implementation
branch
from
4b8f25a to
d0a9d47
Compare
mtdowling
requested changes
Nov 3, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlNodeParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Show resolved
Hide resolved
mtdowling
reviewed
Nov 15, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlNodeParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/SmithyIdlModelSerializer.java
Show resolved
Hide resolved
This adds support for inline definitions of operation input and output shapes. This somewhat reduces necessary boilerplate, and makes the model a bit easier to read since the high level info for an operation is now all in one place. This also updates the IDL serializer to use inlined shapes wherever possible.
JordonPhillips
force-pushed
the
inline-io-implementation
branch
from
560449a to
9c3ab4c
Compare
mtdowling
approved these changes
Dec 7, 2021
kstich
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of: #962
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.