-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Automate Releases #447
Comments
Another reference is the way Finch is doing it: In particular they use release please to automate the releases including generating the changelog. |
Our branching strategy is defined here: https://github.com/awslabs/soci-snapshotter/blob/main/RELEASES.md#releases-1 The last piece is the actual process which is:
We should probably add this documentation somewhere, but not in the releases doc because these instructions are things that only maintainers care about. |
fyi: nerdctl's new release doc for maintainers: https://github.com/containerd/nerdctl/blob/main/MAINTAINERS_GUIDE.md |
A couple more notes that should go into the maintainer's version of the release doc:
|
Should we instead be building with the version in our go.mod (currently 1.18(.latest))? Or the version in our github workflows (currently 1.18.10)? |
Possibly? The go directive in go.mod has really weird semantics. A lot of people interpret it as the "minimum supported go version", which isn't really what it means but it's more-or-less how we're using it. The reason to use a newer version is because we might get not-yet-backported bug fixes or standard library improvements. |
#876 takes care of the AMD64 side. ARM64 remains largely un-automated, though that PR also helps make that process a bit easier. We should keep this open as other options for ARM64 become available/known. |
Is your feature request related to a problem? Please describe.
As we start thinking about releasing binaries of the SOCI snapshotter, it would be good to start thinking about how to make the process repeatable to make sure we don't miss an artifacts or details.
Describe the solution you'd like
Ideally we would have a github actions pipeline that automatically created a github release with all the relevant artifacts whenever we push a tag.
Describe alternatives you've considered
N/A
Additional context
References:
Containerd's workflow https://github.com/containerd/containerd/blob/main/.github/workflows/release.yml
nerdctl's workflow https://github.com/containerd/nerdctl/blob/main/.github/workflows/release.yml
The text was updated successfully, but these errors were encountered: