Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project should use modern python packaging techniques #19

Open
FollowTheProcess opened this issue Jul 29, 2024 · 0 comments
Open

Project should use modern python packaging techniques #19

FollowTheProcess opened this issue Jul 29, 2024 · 0 comments

Comments

@FollowTheProcess
Copy link

FollowTheProcess commented Jul 29, 2024

Hello 👋🏻

I notice this repo still uses setup.py and has some potentially outdated config for modern python packaging. As far as I can tell it should be pretty easy to port to pyproject.toml using PEP621 and using the new PEP517 and PEP518 standards. There are no C extensions to build for instance.

In addition, the project might benefit from some of the more modern python toolset i.e.:

  • Ruff for linting over pylint
  • Introducing gradual typing with e.g. MyPy
  • A modern package manager such as pdm or poetry (others are available too like hatch, flit etc.)

I'd be happy to submit a PR implementing some or all of the above depending on what you do/don't want to be included. I'd suggest the move to storing metadata in pyproject.toml and using the new packaging/build techniques as a minimum

See also: aws-cloudformation/cloudformation-cli#1083

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant