You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I notice this repo still uses setup.py and has some potentially outdated config for modern python packaging. As far as I can tell it should be pretty easy to port to pyproject.toml using PEP621 and using the new PEP517 and PEP518 standards. There are no C extensions to build for instance.
In addition, the project might benefit from some of the more modern python toolset i.e.:
A modern package manager such as pdm or poetry (others are available too like hatch, flit etc.)
I'd be happy to submit a PR implementing some or all of the above depending on what you do/don't want to be included. I'd suggest the move to storing metadata in pyproject.toml and using the new packaging/build techniques as a minimum
Hello 👋🏻
I notice this repo still uses
setup.py
and has some potentially outdated config for modern python packaging. As far as I can tell it should be pretty easy to port topyproject.toml
using PEP621 and using the new PEP517 and PEP518 standards. There are no C extensions to build for instance.In addition, the project might benefit from some of the more modern python toolset i.e.:
I'd be happy to submit a PR implementing some or all of the above depending on what you do/don't want to be included. I'd suggest the move to storing metadata in
pyproject.toml
and using the new packaging/build techniques as a minimumSee also: aws-cloudformation/cloudformation-cli#1083
Thanks!
The text was updated successfully, but these errors were encountered: