We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I just noticed that the total file size calculation possibly has a bug.
It seems that when adding a single file, it will be counted twice for the total size over all files.
How to reproduce
A first look into the source suggests that these two lines probably needs to be flipped.
pattern-library/src/components/20-molecules/file-upload/index.js
Lines 442 to 443 in eca9f02
On line 406, sizeOfAllFilesInBytes already has the value of 512000 when previewing the future total including the new file to be added.
sizeOfAllFilesInBytes
Lines 398 to 413 in eca9f02
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I just noticed that the total file size calculation possibly has a bug.
It seems that when adding a single file, it will be counted twice for the total size over all files.
How to reproduce
Notice that max single file size is capped at 500KB and max size of all files is 999KB
A first look into the source suggests that these two lines probably needs to be flipped.
pattern-library/src/components/20-molecules/file-upload/index.js
Lines 442 to 443 in eca9f02
On line 406,
sizeOfAllFilesInBytes
already has the value of 512000 when previewing the future total including the new file to be added.pattern-library/src/components/20-molecules/file-upload/index.js
Lines 398 to 413 in eca9f02
The text was updated successfully, but these errors were encountered: