Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group related components #683

Closed
1 of 12 tasks
AndyOGo opened this issue Nov 26, 2018 · 2 comments
Closed
1 of 12 tasks

group related components #683

AndyOGo opened this issue Nov 26, 2018 · 2 comments

Comments

@AndyOGo
Copy link

AndyOGo commented Nov 26, 2018

Are you reporting a bug or a feature?

  • Bug
  • Feature

Expected Behavior

All related components should be:

  • together in source and at documentation pages
  • should have their own link/menu item including for all sub components
  • they should be stripped out of organism, molecules or atoms page (only if they are in a group)
  • the build should auto-detect groups
  • create-a-m-o script should be able to initialise a group and maybe to turn an existing component into a grouped component

Affected Components:

  • Header
  • Footer
  • Error Pages
  • Sticky
  • Table

Definition of group is the highest material type possible. For example for Table is the group o-table where all its components are directly under it inside a folder subcomponents. ONLY the components that have a hard coupling should be grouped

@AndyOGo
Copy link
Author

AndyOGo commented Jan 17, 2019

Quote @jackblackCH suggestion from #782 (comment)

The more components we have, it becomes harder to find the desired components (scrolling through a huge prefixed components directory).

It makes it more readable to group it within the directories.
Sidenote: Tools like Fractal, Storybook or other pattern library helpers, allow this sub directories per default.

src/components
  - atoms
     - a-caption
     - a-checkbox
  - molecules
     - m-button
     - m-col
  - organisms
     - o-datepicker

@LucaMele
Copy link
Contributor

Closing as V2 is released. If issue is still relevant in v2, please re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants