Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all task dependencies to suggestions #29

Open
hussainweb opened this issue Dec 22, 2023 · 2 comments
Open

Move all task dependencies to suggestions #29

hussainweb opened this issue Dec 22, 2023 · 2 comments

Comments

@hussainweb
Copy link
Member

We require the following dependencies:

        "dealerdirect/phpcodesniffer-composer-installer": "*",
        "drupal/coder": "^8.3.7",
        "friendsoftwig/twigcs": "^4.0 || ^5.0 || ^6.0",
        "php-parallel-lint/php-parallel-lint": "^1.2",
        "phpcompatibility/php-compatibility": "^9.0",
        "phpmd/phpmd": "^2.8",
        "sebastian/phpcpd": "^3.0 || ^4.0 || ^5.0 || ^6.0"

There is always a possibility that these dependencies could introduce conflicts in some projects. Consider moving them to composer.json suggested rather than require so that the dependencies are not locked.

The problem is if we remove all the dependencies, then our default grumphp config will fail. We will need to make it clear in the documentation that the user is responsible for installing the relevant packages.

@rajeshreeputra
Copy link
Contributor

rajeshreeputra commented Dec 22, 2023

I believe there shouldn't be any issues since Composer is designed to work in various scenarios. In case of conflicts, users can always download the other allowed version.

Note: updated comment

@hussainweb
Copy link
Member Author

@rajeshreeputra, I am not able to figure out what are you advocating for. Are you saying we should keep the dependencies in require or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants