Issue while cleaning up the new instance

[subhojit-axl]

We are using this action to setup feature instances when a developer creates pull request. We have another GitHub action that is supposed to delete the feature instance when the pull request is merged.

name: Do cleanup

on:
  pull_request:
    types: [ closed ]

jobs:
  merge_job:
    # this job will only run if the PR has been merged
    if: github.event.pull_request.merged == true
    runs-on: ubuntu-latest
    container: axelerant/platformsh-cli:latest
    env:
      ENV_NAME: platform
    steps:
      - name: Check out repository code
        uses: actions/checkout@v2
        with:
          fetch-depth: 0

      - name: Terminate instance
        run: |
          platform project:set-remote ${PLATFORM_PROJECT_ID}
          platform environment:deactivate ${GITHUB_REF_NAME} --delete-branch
        env:
          PLATFORMSH_CLI_TOKEN: ${{ secrets.PLATFORMSH_CLI_TOKEN }}

GITHUB_REF_NAME is the branch name to which the pull request is merged, not the pull request's branch name. Due to this it fails to delete the feature instance.

[hussainweb]

The snippet you showed does not use the action at all. What should we change in the action for this?

[subhojit-axl]

We are using this action while creating the instance. This action uses the GITHUB_REF_NAME. Since, the value of the variable is different when a pull request is merged compared to when it is created, we are facing issues in terminating the instance.

[hussainweb]

Do you think we should add support in the action to even terminate instances?

[subhojit-axl]

I don't think so. Although, this can be achieved with the help of a flag, but it would be better if this feature is implemented as a separate action altogether.