-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot publish due to JSR compatibility issues #1
Comments
Hmm, OK fine for the missing explicit return types but... I mean, maybe fuck this bit? I mean I'll do it if it's really going to slow down every
|
well itsche arguably the latter, but complicated, so I suggest you should just take one for the team (..?) |
Well, solving the destructuring thing requires a pretty grotesque mutilation of the public API. I'm not sure, I think I need to sleep on it. In principle, I guess I am OK if it's just a "library author" pain point but... I mean, compare: before:const { factory, type } = ValidatedString.create(
isAlphabeticOrUnderscoreOrHyphen,
{
name: 'AlphabeticOrUnderscoreOrHyphenString',
description: 'must contain only letters (A-Z, a-z), underscores, or hyphens',
},
);
export type AlphabeticOrUnderscoreOrHyphenString = typeof type;
export const AlphabeticOrUnderscoreOrHyphenString = factory; afterconst JSRCompatibleFactory = ValidatedString.create(
isAlphabeticOrUnderscoreOrHyphen,
{
name: 'AlphabeticOrUnderscoreOrHyphenString',
description: 'must contain only letters (A-Z, a-z), underscores, or hyphens',
},
);
const type = JSRCompatibleFactory.type;
const factory = JSRCompatibleFactory.factory; 😅 LOL, OK, OK, I guess you're right, it's not that big of a deal (assuming this solves the issue — additional out-of-band type checking is maybe cool, additional out-of-band linting requirements that only show up during the publishing phase, less so...) updateThe PR is now closed but just to correct the record, it did become kind of a bloodbath: ValidatedString.create(
isAlphabeticOrUnderscoreOrHyphen,
{
name: 'AlphabeticOrUnderscoreOrHyphenString',
description: 'must contain only letters (A-Z, a-z), underscores, or hyphens',
},
);
const type: ValidatedString<typeof isAlphabeticOrUnderscoreOrHyphen> = JSRCompatibleFactory.type;
const factory: ValidatedStringFactory<typeof isAlphabeticOrUnderscoreOrHyphen> = JSRCompatibleFactory.factory;
export type AlphabeticOrUnderscoreOrHyphenString = typeof type;
export const AlphabeticOrUnderscoreOrHyphenString = factory; Not like, worse than human trafficking or using your AC when it's only 26°C but... still. |
OK, I'll "do it" provided that Windsurf can do the actual doing of it... 😆 ![]() |
haha haha you right, this is lame maybe there is way to dry-run? i'm in the pub^Wdiscotheque so i cant check atm |
@masonmark reference https://jsr.io/@axhxrx/validated-string/score may i finally acquiesce to the multitudinous dance invitations i am receiving or would you be needing something else |
Well can you update the easy fields to rev up the JSR score? Should be doable from your phone. Then I will close this. |
ok i fix everything except good luck with it señor |
🫡 roger that |
hey @masonmark JSR says get off the elephant tranquilizer you madman
i'll give it another go-round when i get back from the discotheque if you can fix those problemas
The text was updated successfully, but these errors were encountered: