Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch Postal Code matches invalid postcode #27

Closed
roelofr opened this issue Jan 27, 2021 · 2 comments
Closed

Dutch Postal Code matches invalid postcode #27

roelofr opened this issue Jan 27, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@roelofr
Copy link

roelofr commented Jan 27, 2021

  • PHP: n/a
  • Laravel: n/a
  • Postal code validation: master @ d634176 (resolved from code on GitHub)

Description:

The Dutch regex matches invalid postal codes on two parts:

  1. The postcodes cannot start with a 0, but the regex allows this.
  2. The postcodes cannot end with SA, SD or SS due to the reference to the Stormabteilung, Sicherheitsdienst and the Shutzstaffel. Credit to @wotta for learning me about this.

Steps To Reproduce:

  1. Validate against 0123 AB, 1111 SA or 5949 SS
  2. Get accepted as valid input
@roelofr roelofr added the bug Something isn't working label Jan 27, 2021
@axlon
Copy link
Owner

axlon commented Jan 28, 2021

Hey @roelofr thanks for pointing this out, you should probably create an issue at google/libaddressinput where this data is seeded from.

@axlon
Copy link
Owner

axlon commented Oct 27, 2021

Closing this for now

@axlon axlon closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants