Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove run.js.j2 render hack #1524

Open
fasterthanlime opened this issue Nov 5, 2024 · 0 comments
Open

Remove run.js.j2 render hack #1524

fasterthanlime opened this issue Nov 5, 2024 · 0 comments

Comments

@fasterthanlime
Copy link
Contributor

Currently, the npm backends renders the whole templates/installers/npm folder with the same context (that does NOT have a run field), which breaks "strict undefined behavior". As a result, the following bit was added in #1499:

{%- if bin is defined %}
run({{ bin }});
{%- endif %}

We should do the right thing instead, like... moving run.js.j2 outside of that directory, simply. So that we can render the npm skeleton dir/template, and then all the run.js files we need (per-binary) separately. That's out of scope for #1499 though, so I'm opening this to track a small follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant