Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow pass prompter config #64

Closed
NanoCode012 opened this issue May 26, 2023 · 1 comment
Closed

[Feature] Allow pass prompter config #64

NanoCode012 opened this issue May 26, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@NanoCode012
Copy link
Collaborator

Proposal: Code has been written to accept any Prompter. We should allow this to be configurable using a cfg or kwarg

https://github.com/OpenAccess-AI-Collective/axolotl/blob/bbfc333a0136bfcf3f2129986253a8141c6c64d5/scripts/finetune.py#L188

which is used here

https://github.com/OpenAccess-AI-Collective/axolotl/blob/bbfc333a0136bfcf3f2129986253a8141c6c64d5/scripts/finetune.py#L59-L64
@NanoCode012 NanoCode012 added the enhancement New feature or request label May 26, 2023
@NanoCode012 NanoCode012 mentioned this issue Jun 1, 2023
Closed
@NanoCode012
Copy link
Collaborator Author

As of right now, this has been mainly solved following #183

However, there seems to be some drawback (particularly for conversation) dataset, but since axolotl's main focus is not inference. This may be ok for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NanoCode012