Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 Logic: ♻️ Refactor getLoadedSources to Avoid Reflection in file.go #502

Open
coderabbitai bot opened this issue Jan 13, 2024 · 0 comments
Open
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2024

There's a need to refactor the getLoadedSources function in x/logic/predicate/file.go to avoid using reflection when accessing the loaded field of the VM. This approach is brittle and relies on the internal structure of the VM, which is not ideal.

The issue was identified during the review of PR #501, specifically in the context of standardizing error handling across the x/logic/prolog and x/logic/predicate packages.

A method on the VM should be provided to access this information in a more robust manner.

For more context, see the comment chain in the PR:

@github-project-automation github-project-automation bot moved this to 📋 Backlog in 💻 Development Jan 13, 2024
@ccamel ccamel moved this from 📋 Backlog to 📆 To do in 💻 Development Jan 13, 2024
@ccamel ccamel changed the title Refactor getLoadedSources to Avoid Reflection in file.go 🧠 Logic: ♻️ Refactor getLoadedSources to Avoid Reflection in file.go Jan 13, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in 💻 Development May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants