You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a need to refactor the getLoadedSources function in x/logic/predicate/file.go to avoid using reflection when accessing the loaded field of the VM. This approach is brittle and relies on the internal structure of the VM, which is not ideal.
The issue was identified during the review of PR #501, specifically in the context of standardizing error handling across the x/logic/prolog and x/logic/predicate packages.
A method on the VM should be provided to access this information in a more robust manner.
For more context, see the comment chain in the PR:
ccamel
changed the title
Refactor getLoadedSources to Avoid Reflection in file.go
🧠 Logic: ♻️ Refactor getLoadedSources to Avoid Reflection in file.go
Jan 13, 2024
There's a need to refactor the
getLoadedSources
function inx/logic/predicate/file.go
to avoid using reflection when accessing theloaded
field of theVM
. This approach is brittle and relies on the internal structure of theVM
, which is not ideal.The issue was identified during the review of PR #501, specifically in the context of standardizing error handling across the
x/logic/prolog
andx/logic/predicate
packages.A method on the
VM
should be provided to access this information in a more robust manner.For more context, see the comment chain in the PR:
The text was updated successfully, but these errors were encountered: