Refactor the config.toml, split the consensus parameters.

[yangby-cryptape]

Contact Details

No response

Propose-a-new-feature

What is "consensus parameters"?

If it changed, the chain state will be changed, then it is a consensus parameter.

Why I propose this feature?

Same reason as #1275: the executable binary should be halt when it found the consensus parameters are changed, to make sure no inconsistent data are stored.

My solution is:

• Serialize all consensus parameters in a specify order and calculate a hash, store the hash into storage, check it when axon runs.

But the problem is:

• Consensus parameters are not a separated.

In axon's config.toml:

• accounts section are consensus parameters.

  axon/devtools/chain/config.toml

  Lines 10 to 12 in 8f3eded

  	[[accounts]]
  	address = "0xa0ee7a142d267c1f36714e4a8f75612f20a79720"
  	balance = "04ee2d6d415b85acef8100000000"

• consensus section is consensus parameters.

  axon/devtools/chain/config.toml

  Lines 65 to 66 in 8f3eded

  	[consensus]
  	sync_txs_chunk_size = 5000

• But, other parameters are not consensus parameters, for example, http_listening_address, maxconn and log_path.

In future, there will be more consensus parameters, such as contract_limit, hardfork_height.

So, if those consensus parameters are split, things will be easier.

Alternatives you've considered

No response

Anything else?

No response

[yangby-cryptape]

Some Questions

• Does consensus.sync_txs_chunk_size affect the consensus?

  From its name, it looks like a parameter that how many transactions can be synchronized one time.

  I'm not sure whether it's able to affect the consensus.

• Besides accounts and consensus.sync_txs_chunk_size, is there any other parameters can affect the consensus?

  For example, crosschain_contract_address, wckb_contract_address, executor.light.

[KaoImin]

Does consensus.sync_txs_chunk_size affect the consensus?

No. It only controls how many transactions that will be pull once to reduce the press of network.

Besides accounts and consensus.sync_txs_chunk_size, is there any other parameters can affect the consensus?
For example, crosschain_contract_address, wckb_contract_address, executor.light.

These three configs should be removed. They are outdated.