Enable fatal errors by default

Add #![no_builtins] to all test programs; see
aya-rs/aya#698 for rationale.

Author: tamird

src/bin/bpf-linker.rs

@@ -141,7 +141,7 @@ struct CommandLine {
     export: Vec<String>,
 
     /// Whether to treat LLVM errors as fatal.
-    #[clap(long, action = clap::ArgAction::Set, default_value_t = false)]
+    #[clap(long, action = clap::ArgAction::Set, default_value_t = true)]
     fatal_errors: bool,
 
     // The options below are for wasm-ld compatibility

tests/assembly/auxiliary/dep-section.rs

@@ -1,5 +1,7 @@
 // no-prefer-dynamic
 // compile-flags: --crate-type rlib
+#![no_builtins]
+#![no_main]
 #![no_std]
 
 #[no_mangle]

tests/assembly/auxiliary/dep.rs

@@ -1,8 +1,10 @@
 // no-prefer-dynamic
 // compile-flags: --crate-type rlib
+#![no_builtins]
+#![no_main]
 #![no_std]
 
 #[no_mangle]
 fn some_dep() -> u8 {
     42
-}
+}

tests/assembly/auxiliary/loop-panic-handler.rs

@@ -1,9 +1,10 @@
 // no-prefer-dynamic
 // compile-flags: --crate-type rlib
+#![no_builtins]
+#![no_main]
 #![no_std]
 
 #[panic_handler]
 fn panic_impl(_: &core::panic::PanicInfo) -> ! {
     loop {}
 }
-

tests/assembly/bin.rs

@@ -3,8 +3,9 @@
 
 // Same as bpf-sections.rs, but using bin as crate-type.
 
-#![no_std]
+#![no_builtins]
 #![no_main]
+#![no_std]
 
 // aux-build: loop-panic-handler.rs
 extern crate loop_panic_handler;

tests/assembly/elf-sections.rs

@@ -3,6 +3,8 @@
 
 // BPF crates export programs (functions) and maps (kernel data structures) through ELF sections.
 // Verify that the linker correctly outputs those sections.
+#![no_builtins]
+#![no_main]
 #![no_std]
 
 // aux-build: loop-panic-handler.rs
@@ -22,4 +24,4 @@ static mut COUNTER: u32 = 0;
 
 // CHECK: .section "uprobe/connect","ax"
 // CHECK: .section "uprobe/dep","ax"
-// CHECK: .section "maps/counter","aw"
+// CHECK: .section "maps/counter","aw"

tests/assembly/ignore-inline-never.rs

@@ -1,6 +1,8 @@
 // assembly-output: bpf-linker
 // compile-flags: --crate-type cdylib -C link-args=--ignore-inline-never
 // only-bpfel
+#![no_builtins]
+#![no_main]
 #![no_std]
 
 // Kernels prior to 5.8 (August 2020) don't support function calls. In order to support those

tests/assembly/re-export-symbols.rs

@@ -1,5 +1,7 @@
 // assembly-output: bpf-linker
 // compile-flags: --crate-type cdylib
+#![no_builtins]
+#![no_main]
 #![no_std]
 
 // Check that #[no_mangle] symbols are exported, including those coming from dependency crates.
@@ -15,4 +17,4 @@ fn connect() {
 }
 
 // CHECK: .globl connect
-// CHECK: .globl some_dep
+// CHECK: .globl some_dep

tests/assembly/unroll-loop.rs

@@ -1,6 +1,8 @@
 // ignore-test
 // assembly-output: bpf-linker
 // compile-flags: --crate-type cdylib -C link-arg=--unroll-loops -C link-arg=-O3
+#![no_builtins]
+#![no_main]
 #![no_std]
 // Recent kernels starting from 5.2 support some bounded loops. Older kernels need all loops to be
 // unrolled. The linker provides the --unroll-loops flag to aggressively try and unroll.