Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements should have sufficient color contrast (followup) #321

Open
akslay opened this issue Jun 30, 2021 · 3 comments
Open

Elements should have sufficient color contrast (followup) #321

akslay opened this issue Jun 30, 2021 · 3 comments
Labels
5.x 5.x specific accessibility bug Something isn't working

Comments

@akslay
Copy link
Contributor

akslay commented Jun 30, 2021

Problem/Motivation

Related to #309

The horizontal rule element stays the same color regardless of background color, making it inaccessible on darker background colors.

Proposed resolution

Add the <hr> tag to the SCSS that ensures proper color contrast; it should match the color of the text.

In general, might need to just throw every possible element on a dark background color to make sure we caught everything (I'm coming across these as I add elements to the CKEditor in AZ Quickstart 2.0).

@akslay akslay added the bug Something isn't working label Jun 30, 2021
@akslay akslay self-assigned this Jun 30, 2021
@trackleft
Copy link
Member

Is there an WCAG recommendation for this?

@akslay
Copy link
Contributor Author

akslay commented Apr 8, 2022

I didn't find anything about horizontal rules specifically on WCAG, but I would think an <hr /> should have the same level of color contrast as text, right?

@akslay
Copy link
Contributor Author

akslay commented May 25, 2022

Another item that needs to leverage the built-in color contrast: text inside tables.
Screen Shot 2022-05-25 at 2 58 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x 5.x specific accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants