Flip order for env vs flag for server attributes #971
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves configuration from env variables first for server with transactions and with tiles. The
orFalse
on the flag was necessary to turn it into anOpt[Bool]
, but it was also making it so that the CLIChecklist
New tests have been added or existing tests have been modifiednot super straightforward to test configuration options 😢 maybe continuous configuration testing will help with some ideasTesting Instructions
API_WITH_TRANSACTIONS=true ./sbt
application/run serve --db-host=localhost
http :9090/open-api/spec.yaml | grep delete
-- you should get a hitapplication/run serve --db-host=localhost --with-tiles
http :9090/open-api/spec.yaml | grep tiles
-- you should get a hithttp :9090/open-api/spec.yaml | grep delete
-- you should get a hitAPI_WITH_TILES=true ./sbt
--with-transactions
and check for both -- you should expect hitsCloses #969