-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the version of json-editor in the schema editor #29
Comments
I did a quick audit of the changes made by the Azavea
In brief: most of these features have not been brought into the codebase. I can see a few opportunities for PRs into the community fork. Some features that they would probably appreciate: However, the rest of the features are pretty specific to our implementation. This leads me to wonder: what's the best path forward for upgrading? I can see two options:
Is there a better way of thinking about this problem that I'm missing? |
No, I think those two options about sum it up; we've run into this situation before where we wanted to fork a project but also stay updated with upstream. We generally went with approach 1, so I think I'd lean toward that. However, I will say that I think reducing the footprint of the Azavea-specific changes will help to keep maintenance costs low, so it's probably still valuable to make PRs to the community fork wherever possible. |
The schema editor currently uses an Azavea-maintained fork of Jeremy Dorn's
json-editor
library. Jeremy Dorn's version of the library has since been deprecated in favor of a community-maintained fork.We should update the schema editor to use the actively-maintained version of JSON Editor. This work will involve auditing the Azavea fork to see what features we use that aren't in core, and making sure that those changes are included in whatever version we use (whether it means updating the Azavea fork, or trying to get those changes accepted into the core).
The text was updated successfully, but these errors were encountered: