Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities #2

Closed
nataly-chobat opened this issue Jul 2, 2018 · 3 comments
Closed

Vulnerabilities #2

nataly-chobat opened this issue Jul 2, 2018 · 3 comments

Comments

@nataly-chobat
Copy link

nataly-chobat commented Jul 2, 2018

Could you please update dependencies?
react-app-rewire-scss > node-sass > request > tunnel-agent
react-app-rewire-scss > node-sass > request > hawk > sntp > hoek
react-app-rewire-scss > node-sass > request > hawk > hoek
react-app-rewire-scss > node-sass > request > hawk > cryptiles > boom > hoek
react-app-rewire-scss > node-sass > request > hawk > boom > hoek

The message about these vulnerabilities are really annoying every time when install new package. If it is possible from your side, please, fix it.

All info about vulnerabilities can be seen after running command npm audit.

Also thanks for such great package which helps to reduce a lot of time in development!

@aze3ma
Copy link
Owner

aze3ma commented Jul 4, 2018

@nataly-chobat Thank you.

I think it's from node-sass side so they depends on outdated version of hoek@2.16.3 you can check #2352
#2288
#2262
#2252
#2256
#2170
also you're more than welcome if you want to file a PR.

@nataly-chobat
Copy link
Author

nataly-chobat commented Jul 4, 2018

thanks for your answer!
You absolutely right, these vulnerabilities are caused by node-sass

Another question: why do you include less loader if it is not devMode?

if (devMode) {
      sassRules = {
				test: sassExtension,
				use: [...cssRules.use, { loader: 'sass-loader', options: sassLoaderOptions }],
			};
		} else {
			sassRules = {
				test: sassExtension,
				use: [...cssRules.loader, { loader: 'less-loader', options: lessLoaderOptions }],
			};
		}

@aze3ma
Copy link
Owner

aze3ma commented Jul 4, 2018

@nataly-chobat Sorry it was wrong one SOLVED.

@aze3ma aze3ma closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants