Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all button for notifications #17

Closed
opsb opened this issue Sep 8, 2021 · 6 comments
Closed

Close all button for notifications #17

opsb opened this issue Sep 8, 2021 · 6 comments
Labels
UX problem When something is working but not clear enough

Comments

@opsb
Copy link

opsb commented Sep 8, 2021

Parsing my postgres schema generated a large number of errors. None of them were important so I was happy to ignore them all but I was left with a large number of notifications to close. A close all button would be really handy.

(happy to open a PR if we agree the design)

@opsb
Copy link
Author

opsb commented Sep 8, 2021

Regarding UX, maybe it could be cmd-click? I see there aren't any key combos in the project yet. https://package.elm-lang.org/packages/ohanhi/keyboard/latest/Keyboard could be an option.

@loicknuchel loicknuchel added the UX problem When something is working but not clear enough label Sep 8, 2021
@loicknuchel
Copy link
Contributor

Hi, in fact there is a close button but it's on the right, quite small and sometimes not really visible 😞
So yes, could be largely improved :D

An cmd-click option could be fine also (but not sure how to tell it to users ^^).

Will be happy to review a PR from you 👍

@hansvb
Copy link

hansvb commented Sep 30, 2021

Slightly related (small nuisance so maybe not worth a separate issue): when I scroll using touchpad over the (red) errors, when my mousepointer is on the background-area (gray) it scrolls the background-area instead. It would be better if all the errors were in one (transparent) container-widget?
image

@loicknuchel
Copy link
Contributor

Hi @hansvb

Thanks for your comment.
It's clearly a not ideal UI and I'm currently looking into improving it.

My current take is to move away from this "quick and dirty" UI and open a report modal at the end of the import with some logs inside, so it's clearer for you to see what happened.

What do you think about this?

@loicknuchel
Copy link
Contributor

Hi everyone,

I'm working on a new UI that will improve this and just wanted your feedback on my current (new) design:

screencapture-localhost-8000-projects-new-2021-12-02-07_54_24

What do you think?

@loicknuchel
Copy link
Contributor

Hi @opsb and @hansvb
I finally finished and deployed my UI revamp. I drastically changed the project creation and it should be much better now so I will close this issue.
Feel free to open again or other if you see some possible improvements.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX problem When something is working but not clear enough
Projects
None yet
Development

No branches or pull requests

3 participants