Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always insert state in stored states current and states goal. #138

Closed
4 tasks
azriel91 opened this issue Jun 14, 2023 · 0 comments · Fixed by #139
Closed
4 tasks

Always insert state in stored states current and states goal. #138

azriel91 opened this issue Jun 14, 2023 · 0 comments · Fixed by #139

Comments

@azriel91
Copy link
Owner

azriel91 commented Jun 14, 2023 •
edited
Loading

Currently serialized states_current and states_goal do not include entries for items whose try_state_current and try_state_goal return None.

Perhaps we should change Item::try_state_* to return a State::Partial. maybe later

Tasks

  • StatesSerde should hold unknown entries (removed items).
  • States should be mapped From<StatesSerde> after deserialization.
  • Users should be informed when there are unknown entries.
  • States should be mapped Into<StatesSerde>, with an entry for each item in the flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@azriel91