-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): use name as namespace #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
changed the title
fix(storage): add name as namespace
fix(storage): use name as namespace
Feb 16, 2022
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b5857bd:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
@kvs/storage
does not separate key per storage.This PR aim to fix this issue #20
However, It need to change saved storage's key. It is a BREAKING CHANGE.
We need to bump it as major update.
Affected Packages
@kvs/env
in Node.js@kvs/storage
@kvs/localstorage
@kvs/memorystorage
@kvs/node-localstorage
@kvs/storage-sync
Previous: storage save
value
withkey
This PR: storage save value with
${name}.__.${key}
.It means that kvs package can not load value which is saved by previous version.
Migration
You need to write manuall migration code using
upgrade
.If you have used
@kvs/localstorage
, you can write following.Unfortunately, this migration should use raw
localStorage
API because@kvs/localstorage
can not access the key which is created in kvs 1.x.@kvs/localstorage
localStorage
@kvs/memorystorage
@kvs/node-localstorage
node-localstorage
@kvs/env
in Node.jsnode-localstorage
TODO
storage
storage-sync
fix #20