Allow custom scroll container #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to set scroll containers other than the wrapped component for more custom implementations
|
Please look here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set scroll containers other than the wrapped
component for more custom implementations.
For example, combining
react-dnd-scrollzonewithreact-virtualized, and usingWindowScrollerwith thescrollElementprop,react-dnd-scrollzoneneeds a way to set itscontaineras the samescrollElementthatWindowScrolleruses to properly listen on scrollable areas.This is somewhat different than #20, as this change allows you to manually set the scroll container you want to use.
Fixes #32
Tested in Chrome, Safari, FireFox, and IE11