Add ASIC namespace ID to core filename, if any #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any, add it to core filename as <bnary name>.<timestamp>.<local pid inside container>.<ns>.core.gz. e.g. orchagent.1599073263.45.5.core.gz <-- 5 is the asic namespace. For processes that don't have asic namespace, there is no change. e.g. snmpd.1599073245.27.core.gz The /etc/sysctl.conf kernel.core_pattern is set to pass `pid in host` as last arg.
|
retest this please |
lguohan
approved these changes
Sep 2, 2020
|
retest this please. |
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
Look for namespace of this process in crashing process's environ file.If any, add it to core filename as < binary name >.< timestamp >.< local pid inside container >.< ns > .core.gz. e.g. orchagent.1599073263.45.5.core.gz <-- 5 is the asic namespace. For processes that don't have asic namespace, there is no change. e.g. snmpd.1599073245.27.core.gz The /etc/sysctl.conf kernel.core_pattern is set to pass pid in host as last arg.
3 tasks
Merged
2 tasks
3 tasks
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Fix error when running 'show lldp table' or 'show lldp neighbor' through SSH command. (sonic-net#1067) [201911]: Multi asic show interface support (sonic-net#1070) [counterpoll] Add new FC group for port buffer drop counters (sonic-net#1024) [201911] show interface portchannel support for Multi ASIC (sonic-net#1071) Fix a typo in mellanox_buffer_migrator (sonic-net#1090) Fix pfcwd stats crash with invalid queue name (sonic-net#1077) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018) enable watchdog before running platform specific reboot plugin (sonic-net#1037) Add namespace of the process in the coredump filename. (sonic-net#1091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Look for namespace of this process in crashing process's environ file.If any, add it to core filename as
< binary name >.< timestamp >.< local pid inside container >.< ns > .core.gz.
e.g. orchagent.1599073263.45.5.core.gz <-- 5 is the asic namespace.
For processes that don't have asic namespace, there is no change.
e.g. snmpd.1599073245.27.core.gz
The /etc/sysctl.conf kernel.core_pattern is set to pass
pid in hostas last arg.
- How I did it
- How to verify it
Crash a process running in a namespace and another process that is not running in a namepsace and verify, the core filenames.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)