Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the point? #15

Open
anilanar opened this issue May 2, 2019 · 4 comments
Open

What's the point? #15

anilanar opened this issue May 2, 2019 · 4 comments

Comments

@anilanar
Copy link

anilanar commented May 2, 2019

This runner uses transpileModule function from Typescript compiler API which does not type check. If so, what's the point of jest-runner-tsc?

@christopherscott
Copy link

christopherscott commented May 3, 2019

I agree w/ @anilanar; our team will probably move to simply using tsc --noEmit directly for type-checking test.

See microsoft/TypeScript#4864 for TypeScript team's rationale on why transpileModule doesn't report semantic errors.

Probably overkill, but I made a simple TS to repro this and collect links to some issues:
https://github.com/christopherscott/jest-runner-tsc-transpile-module

@azz
Copy link
Owner

azz commented May 4, 2019

It's a bug, this was a regression because of #14. We're still looking for a solution.

@azz
Copy link
Owner

azz commented May 4, 2019

Going to revert that for now.

@anilanar
Copy link
Author

anilanar commented May 4, 2019

I guess jest runner is not a good solution for project-wide lints/compiles/analysis. We should create an alternative runner that can also run jest, that supports watch mode and prints in a nice visual way with parallelism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants