C or C++

[pianoslum]

Even though the game's language is c++ the code is very c-like, which leads to clumsy function calls like is_human_faction() - this could be expressed more elegantly using a class with a fitting interface.
Do you think the code was written that way or is this due to the decompilation?
Any plans to use clearer classes in the future?

[b-casey]

It's how the original code was written. Mix of c style functions and c++ classes. The is_human() function is something I created to try and reduce code complexity. Any function that has the original offset set to "n/a" in the comments area means it likely didn't exist in the binary and is something I've added. There are some cases where the macOS binary had a certain function but it was optimized out or inlined in the Windows version so no offset existed. Pretty sure I've added a note if this was the case.

This is an example of what is_human() looks like inside the original code with ESI being the faction_id:

This might have been a macro that got inlined, not sure. Either way, any reference you see to is_human() was inlined with the assembly above in the original code. Right now, the code needs to straddle how old style is doing things to work with the existing binary. Once all references to a particular global are decompiled, a cleaner method of having a variable inside the Player or PlayerData struct is likely better option.

[bluddy]

Piggy-backing onto this, have you seen ghidra, @b-casey? It's a pretty amazing decompiler/IDA-equivalent. Might make your efforts much faster.

e.g. without any added input:

void __fastcall FUN_00516da0(int param_1)

{
  int iVar1;
  int iVar2;
  undefined4 uVar3;
  char *_Source;
  byte *pbVar4;
  byte *local_8;
  
  if ((((DAT_0093a938 == 0) && (*(int *)(param_1 + 0x23be8) != 0)) &&
      (((byte)DAT_009a64e8 & (byte)(1 << ((byte)DAT_00939284 & 0x1f))) != 0)) &&
     ((iVar1 = FUN_005bf3f0(s_GOVERNORCONTROL_0068aa24,0x40,0), -1 < iVar1 &&
      (iVar2 = 0, 0 < DAT_009a64cc)))) {
    pbVar4 = &DAT_0097d044;
    while (*pbVar4 != DAT_00939284) {
      iVar2 = iVar2 + 1;
      pbVar4 = pbVar4 + 0x134;
      if (DAT_009a64cc <= iVar2) {
        return;
      }
    }
    if (iVar2 < DAT_009a64cc) {
      if (iVar1 == 5) {
        FUN_004e39d0(iVar2);
        iVar2 = FUN_00419a90(1);
        if (iVar2 != 0) {
          return;
        }
      }
      iVar2 = FUN_00539820(0x32);
      if (iVar2 == 0) {
        DAT_009b86a0 = 0;
        iVar2 = 0;
        if (0 < DAT_009a64cc) {
          local_8 = &DAT_0097d044;
          do {
            if (*local_8 == DAT_00939284) {
              switch(iVar1) {
              case 0:
                *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) & 0x7fffffff;
                *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) & 0xf0ffffff;
                uVar3 = *(undefined4 *)(DAT_009b90f8 + 0xaf8);
                break;
              case 1:
              case 2:
              case 3:
              case 4:
                *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) | 0x80000000;
                *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) & 0xf0ffffff;
                switch(iVar1) {
                case 1:
                  *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) | 0x1000000;
                  uVar3 = *(undefined4 *)(DAT_009b90f8 + 0x824);
                  break;
                case 2:
                  *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) | 0x2000000;
                  uVar3 = *(undefined4 *)(DAT_009b90f8 + 0x828);
                  break;
                case 3:
                  *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) | 0x4000000;
                  uVar3 = *(undefined4 *)(DAT_009b90f8 + 0x82c);
                  break;
                case 4:
                  *(uint *)(DAT_0090ea30 + 0x38) = *(uint *)(DAT_0090ea30 + 0x38) | 0x8000000;
                  uVar3 = *(undefined4 *)(DAT_009b90f8 + 0x830);
                  break;
                default:
                  goto switchD_00516eb4_caseD_6;
                }
                break;
              case 5:
                *(undefined4 *)(DAT_0090ea30 + 0x38) =
                     *(undefined4 *)(&DAT_0096cbb0 + *(int *)(param_1 + 0x23bd4) * 0x20cc);
                uVar3 = *(undefined4 *)(DAT_009b90f8 + 0xafc);
                break;
              default:
                goto switchD_00516eb4_caseD_6;
              }
              _Source = (char *)FUN_006169a0(uVar3);
              FID_conflict:_strcat(&DAT_009b86a0,_Source);
            }
switchD_00516eb4_caseD_6:
            iVar2 = iVar2 + 1;
            local_8 = local_8 + 0x134;
          } while (iVar2 < DAT_009a64cc);
        }
        FUN_00625ec0(0,&DAT_009b86a0,0xffffffff,0xffffffff);
        FUN_0047a890(s_GOVERNORCONTROLDONE_0068aa34,&DAT_00001388,0,0);
        FUN_005398c0();
      }
    }
  }
  return;
}