Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportAdder.exe clarification #41

Open
kaithar opened this issue Jun 27, 2021 · 1 comment
Open

ImportAdder.exe clarification #41

kaithar opened this issue Jun 27, 2021 · 1 comment

Comments

@kaithar
Copy link

kaithar commented Jun 27, 2021

It might just be me being stupid somehow, but could you clarify what/where ImportAdder.exe comes from?

The thought process that leadto this question is, approximately:

  • I roughly understand what it does from looking at the patcher script, but there seems to be no code corresponding to it?
  • I thought it might be a standard external tool, but the commit history suggests otherwise even without the project specific data.
  • I considered that it might be auto generated by VS's default dll project (and I haven't ruled that out, actually), but does codeblocks generate something similar?
  • It is, perhaps, a standard windows injection technique (something I admit I wouldn't be familiar with), but without knowing how it functions or how to update it to match any changes to the dll, it's not a reproducible artefact but is fairly critical to development.
  • Resorting to the simplest solution... ask 👍
@induktio
Copy link
Collaborator

induktio commented Dec 7, 2021

Yeah, this part does not contain the actual compilation steps in the repo. As far as I know, it's not a standard tool, but it uses PEfile sources modified to patch some specific OpenSMACX imports on terranx.exe binary. It might also be a question of licences if it can be incorporated in the source. Maybe that's why Scient didn't include it. The patcher is probably not a complicated program to implement but some solution needs to be found so that the build artifacts are reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants