Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] AddBookmark function keybinding #45

Open
Neurognostic opened this issue Aug 8, 2021 · 1 comment
Open

[Feature Request] AddBookmark function keybinding #45

Neurognostic opened this issue Aug 8, 2021 · 1 comment

Comments

@Neurognostic
Copy link

  • Surfingkeys Version: 0.9.74
  • Surfingkeys-conf Version (git hash): 9623762
  • Operating System: Linux
  • Browser Version: Firefox 90.0.2

Details

I was not able to find any functionality in this config to add/create a bookmark. In the default config it's mapped to ab.

From the default Sufingkeys config:

mapkey('ab', '#8Bookmark current page to selected folder', function() {
    var page = {
        url: window.location.href,
        title: document.title
    };
    Front.openOmnibar(({type: "AddBookmark", extra: page}));
});

Am I just missing it?

Thank you.

@ned-si
Copy link

ned-si commented May 30, 2024

In case anyone's watching this, actually you can just delete this line and it will work just fine :)

https://github.com/b0o/surfingkeys-conf/blob/main/src/keys.js#L33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants