Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Decide on the final API #2

Open
tomek-he-him opened this issue Jul 25, 2015 · 1 comment
Open

Decide on the final API #2

tomek-he-him opened this issue Jul 25, 2015 · 1 comment

Comments

@tomek-he-him
Copy link

There seems to be some disagreement in the community as to where data should land.

  1. Some say data should come last. Not without reason.
  2. There’s a new function bind proposal which can result in very elegant code. There seems to be a lot of excitement about that.
  3. At the moment we have traditional here – data as the first parameter.

Should we keep it this way (3)? Should we go with the flow (2)? Should we perhaps allow different APIs for different purposes?

const isSubset = require('is-subset/data-last');     // 1
const isSubset = require('is-subset/data-as-this');  // 2
const isSubset = require('is-subset');               // 3

I hope for some discussion here :)

@tomek-he-him
Copy link
Author

Alright, this module doesn’t have much audience – so I’ve moved the discussion to mattdesl/module-best-practices#7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant