Skip to content
This repository has been archived by the owner on Aug 1, 2021. It is now read-only.

dependency version ranges #183

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

casperdcl
Copy link
Contributor

Use version ranges for dependencies; making things more future-proof and less likely to need version bumping again.

@casperdcl
Copy link
Contributor Author

It's also possible that gevent could be >=1.3.6 or >=1.2.2 or >=1.2.1, possibly even earlier.

Also requests could be >=2.18.4 or >=2.13.0, or earlier.

Really based on the commit history that version bumps were only applied "because an upsteam package was updated" rather than out of necessity. This completely violates the purpose of version ranges, and also is incorrect since disco doesn't require specific versions. It also makes it extremely likely for disco to incorrectly cause dependency hell.

Without this PR, any other package which also uses e.g. requests and decides to pin exact versions would be almost guaranteed to be incompatible with disco.

@elderlabs
Copy link
Contributor

A group of us have begun our own off-shoot of Disco and plan to provide updates for those still running Python2 (for whatever reason) and Python3 under API v8. There will be separate branches for each version (given six is a bloody mess/nightmare and is terrible at maintaining Python version compatibility -- hint: it causes crashes), and updates will be maintained ideally as information's provided by Discord. I should have more details soon:tm:.

@b1naryth1ef b1naryth1ef merged commit a1fbeb7 into b1naryth1ef:master Oct 27, 2020
@casperdcl casperdcl deleted the requirements branch October 28, 2020 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release on pypi Python 3.8 Support Python 3.7 support
3 participants